Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shengwei fix jae account update permission issue #649

Merged

Conversation

ptrpengdev
Copy link
Contributor

Description

image

Related PRS (if any):

This PR is related to the FE PR1681

Main changes explained:

  • Update src/controllers/badgeController.js to modify how a new badge collection is created and to match the date format for the last modified field in the badge collection schema.
  • Create a generic exception handler file that logs exceptions to Sentry and logs error stack traces while in local development.

How to test:

  1. check into the current branch and FE PR1681
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Refer to FE PR1681

Note:

I will create a follow-up PR to address the edit restriction on Jae's account in the badge management component. The bug related to incorrect badge assignment is causing a block.

Copy link
Contributor

@this-journey this-journey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I left a review with videos on the front end. Well done!

…nto shengwei_fix_jae_account_update_permission_issue
…nto shengwei_fix_jae_account_update_permission_issue
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Feb 3, 2024
Copy link

@SaiDeepak-NEU SaiDeepak-NEU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the changes and everything worked as expected.

Please check the frontend PR1681 for my comments.

…nto shengwei_fix_jae_account_update_permission_issue
@one-community one-community merged commit 65e58e2 into development Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants